make hardcoded max ratio for failures in adjust_permissions configurable#2213
Merged
boegel merged 1 commit intoeasybuilders:developfrom May 11, 2017
Merged
make hardcoded max ratio for failures in adjust_permissions configurable#2213boegel merged 1 commit intoeasybuilders:developfrom
boegel merged 1 commit intoeasybuilders:developfrom
Conversation
Contributor
|
lgtm - <3 it - with thanks! amazing how the test case is so much bigger than the fix, hm?! |
Member
Author
|
@fgeorgatos well, I was just being thorough, doesn't hurt :) |
wpoely86
approved these changes
May 11, 2017
Member
Author
|
Thanks for the review @fgeorgatos and @wpoely86! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #2212
cc @fgeorgatos