Skip to content

get rid of references to hpcugent after move to github.com/easybuilders#2261

Merged
wpoely86 merged 7 commits intoeasybuilders:developfrom
boegel:migration_to_easybuilders
Jul 7, 2017
Merged

get rid of references to hpcugent after move to github.com/easybuilders#2261
wpoely86 merged 7 commits intoeasybuilders:developfrom
boegel:migration_to_easybuilders

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jul 6, 2017

last changes (hopefully) related to the migration to github.com/easybuilders

@boegel boegel added this to the 3.3.1 milestone Jul 6, 2017
@boegel boegel requested a review from a team July 6, 2017 19:41
@easybuilders easybuilders deleted a comment from boegelbot Jul 6, 2017
Comment thread RELEASE_NOTES Outdated
- see http://easybuild.readthedocs.org/en/latest/Using_external_modules.html
- add experimental support for Cray toolchains on top of PrgEnv modules: CrayGNU, CrayIntel, CrayCCE (#1234, #1268)
- see https://github.com/hpcugent/easybuild/wiki/EasyBuild-on-Cray for more information
- see http://easybuild.readthedocs.io/en/latest/Cray-support.html for more information
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too important, but why drop https?

Comment thread RELEASE_NOTES Outdated
- this requires specifying a GitHub username for which a GitHub token is available, using --github-user
- with --dump-test-report, the test report can simply be dumped to file rather than being uploaded to GitHub
- see also https://github.com/hpcugent/easybuild/wiki/Review-process-for-contributions#testing-result
- see also http://easybuild.readthedocs.io/en/latest/Integration_with_GitHub.html#uploading-test-reports-upload-test-report
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous comment

Comment thread RELEASE_NOTES Outdated

feature + bugfix release
- added script to bootstrap EasyBuild with EasyBuild, see https://github.com/hpcugent/easybuild/wiki/Bootstrapping-EasyBuild (#531)
- added script to bootstrap EasyBuild with EasyBuild, see http://easybuild.readthedocs.io/en/latest/Installation.html#bootstrapping-easybuild (#531)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Comment thread README.rst Outdated

The code in the ``vsc`` directory originally comes from the *vsc-base* package
(https://github.com/hpcugent/vsc-base).
(https://github.com/easybuilders/vsc-base).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vsc-base hasn't been migrated

Comment thread easybuild/tools/options.py Outdated
# to fix known issue, cfr. https://github.com/hpcugent/vsc-base/issues/152;
# inspired by https://github.com/hpcugent/vsc-base/pull/151
# this fixes https://github.com/hpcugent/easybuild-framework/issues/1438
# to fix known issue, cfr. https://github.com/easybuilders/vsc-base/issues/152;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vsc-base hasn't been migrated

Comment thread easybuild/tools/options.py Outdated
# inspired by https://github.com/hpcugent/vsc-base/pull/151
# this fixes https://github.com/hpcugent/easybuild-framework/issues/1438
# to fix known issue, cfr. https://github.com/easybuilders/vsc-base/issues/152;
# inspired by https://github.com/easybuilders/vsc-base/pull/151
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same

Comment thread test/framework/easyconfig.py Outdated
' "9e9485921c6afe15f62aedfead2c8f6e",', # MD5 checksum for source (gzip-1.4.eb)
' "8ebc2c32692be9ee61eadc5d650cd288",', # MD5 checksum for patch (toy-0.0.eb)
' "2dc55aee0346ad5e4f0c2e46d554a92e",', # MD5 checksum for source (gzip-1.4.eb)
' "c8308888dca8bc2ea62efb22be445414",', # MD5 checksum for patch (toy-0.0.eb)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are kind of migrating to sha256, maybe change the hash here?

@damianam
Copy link
Copy Markdown
Member

damianam commented Jul 7, 2017

@boegel looks good to me, but being so many files I think it makes sense to ask for another pair of eyes to take a look, chances are that I overlooked something.

Comment thread test/framework/github.py
# test account, for which a token may be available
GITHUB_TEST_ACCOUNT = 'easybuild_test'
# the user who's repo to test
# the user & repo to use in this test (https://github.com/hpcugent/testrepository)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this one too?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe I could... Not sure it's worth the trouble though?

@wpoely86 wpoely86 merged commit 2178a5e into easybuilders:develop Jul 7, 2017
@boegel boegel deleted the migration_to_easybuilders branch July 7, 2017 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants