Make recursive-unload not generate load storms.#2316
Merged
boegel merged 3 commits intoeasybuilders:developfrom Sep 29, 2017
Merged
Make recursive-unload not generate load storms.#2316boegel merged 3 commits intoeasybuilders:developfrom
boegel merged 3 commits intoeasybuilders:developfrom
Conversation
Protect the load("module") with
isloaded("module") or mode() == "unload"
that way we get recursive unload without risking load storms with Lmod.
boegel
requested changes
Sep 28, 2017
| # to "module unload" | ||
| load_statement = [self.conditional_statement('isloaded("%(mod_name)s") or mode() == "unload"', '\n'.join(body), negative=True)] | ||
| else: | ||
| load_statement = [self.conditional_statement('isloaded("%(mod_name)s")', '\n'.join(body), negative=True)] |
Member
There was a problem hiding this comment.
@akesandgren This is a bit too copy-pasta, let's change this too the below, and include a reference to http://lmod.readthedocs.io/en/latest/210_load_storms.html:
if build_option('recursive_mod_unload') or recursive_unload:
# ...
# see also http://lmod.readthedocs.io/en/latest/210_load_storms.html
load_guard = isloaded("%(mod_name)s") or mode() == "unload"'
else:
load_guard = 'isloaded("%(mod_name)s")'
load_statement = [self.conditional_statement(load_guard, '\n'.join(body), negative=True)]
Member
|
@akesandgren Oh, and you'll need to fix the broken test, obviously. You ran run the test in isolation (sort of) using |
… guard and actual statement generation. Also add reference to Lmod documentation for this.
boegel
approved these changes
Sep 29, 2017
Member
|
Thanks for the great fix @akesandgren. Just for context:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protect the load("module") with
isloaded("module") or mode() == "unload"
that way we get recursive unload without risking load storms with Lmod.