Skip to content

skip testing of --preview-pr if no GitHub token is available#2348

Merged
wpoely86 merged 1 commit intoeasybuilders:developfrom
boegel:preview_pr_test_github_token
Nov 20, 2017
Merged

skip testing of --preview-pr if no GitHub token is available#2348
wpoely86 merged 1 commit intoeasybuilders:developfrom
boegel:preview_pr_test_github_token

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 20, 2017

This test often fails due to GitHub rate limiting, which is quite annoying, so it should only be run if a GitHub token is available for testing with (just like we already do for tests related to GitHub integration features).

@boegel boegel added the bug fix label Nov 20, 2017
@boegel boegel added this to the 3.5.0 milestone Nov 20, 2017
@boegel boegel changed the title skip testing of --preview-pr if not GitHub token is available skip testing of --preview-pr if no GitHub token is available Nov 20, 2017
@wpoely86 wpoely86 merged commit 008e66f into easybuilders:develop Nov 20, 2017
@boegel boegel deleted the preview_pr_test_github_token branch November 20, 2017 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants