Added functionality to skip devel module with naming scheme#2374
Added functionality to skip devel module with naming scheme#2374boegel merged 3 commits intoeasybuilders:developfrom
Conversation
|
the failed test looks like a network hiccup.. |
|
@jdonners It most likely is, I've re-triggered the test. |
|
|
||
| if not ActiveMNS().mns.det_generate_devel_module(): | ||
| self.log.info("Skipping devel module...") | ||
| return |
There was a problem hiding this comment.
Hmm, we try to avoid inline return statements across the codebase (doesn't help with readability).
To avoid changing indentation in this whole method, why not change the condition that guards the (only) call to make_devel_module instead to include and ActiveMNS().mns.det_generate_devel_module()?
|
|
||
| def det_generate_devel_module(self): | ||
| """ | ||
| Determine if a devel module should be generated. Can be used to create a separate set of modules with a different naming scheme. |
There was a problem hiding this comment.
line too long (> 120 chars), easy/sensible fix is to move 2nd sentence to new line
|
should I create another wrapper function for det_generate_devel_module in ActiveMNS()? I'm not sure what it's meant for.. |
|
and I could just rename the function to |
|
Hi @boegel, is there something else you'd like to see changed about this pull request? |
|
@jdonners Tests in Travis fail on version check for bootstrap script, which is clearly not related to the changes you made. Can you sync your branch with current |
|
Looks good, thanks @jdonners! |
So far, we have installed all modules with the default naming scheme. I would like to install a separate set of modules with a lowercase naming scheme (I know about the caveats of using such a scheme). This change allows to install an alternative set of modules that points to the same installation directory, without overwriting the devel module. I also attached the lowercase naming scheme that I used (I had to rename it from
.pyto.txt).lowercase_easybuild_mns.txt