New command-line option --job-max-jobs to cap nr of submitted build jobs#2378
Merged
boegel merged 4 commits intoeasybuilders:developfrom Mar 16, 2018
Merged
New command-line option --job-max-jobs to cap nr of submitted build jobs#2378boegel merged 4 commits intoeasybuilders:developfrom
--job-max-jobs to cap nr of submitted build jobs#2378boegel merged 4 commits intoeasybuilders:developfrom
Conversation
Contributor
Author
|
(Well, maybe the option name was not so well-chosen...) |
…Engine.max_in_flight` Many thanks to Theofilos Manitaras for noticing and suggesting the fix!
boegel
reviewed
Mar 14, 2018
| opts = OrderedDict({ | ||
| 'backend-config': ("Configuration file for job backend", None, 'store', None), | ||
| 'cores': ("Number of cores to request per job", 'int', 'store', None), | ||
| 'max-jobs': ("Maximum number of concurrent jobs (queued or running)", 'int', 'store', 50), |
Member
There was a problem hiding this comment.
@riccardomurri Shouldn't we set to default to 0 (which I'm guessing means no limit), to maintain current behaviour?
In any case, 50 seems so arbitrary...
Thoughts @victorusu?
Contributor
Author
|
Good catch. Thanks @boegel ! (50 is the default that we have in GC3Pie's |
boegel
approved these changes
Mar 16, 2018
Member
|
Thanks @riccardomurri! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.