update bootstrap script to be compatible with Modules v4#2390
Merged
boegel merged 7 commits intoeasybuilders:developfrom Feb 2, 2018
xdelaruelle:bootstrap_modules_v4
Merged
update bootstrap script to be compatible with Modules v4#2390boegel merged 7 commits intoeasybuilders:developfrom xdelaruelle:bootstrap_modules_v4
boegel merged 7 commits intoeasybuilders:developfrom
xdelaruelle:bootstrap_modules_v4
Conversation
…mentModules and EnvironmentModulesTcl modules tool
…ommand is modulecmd.tcl introduce a is_modulecmd_tcl_modulestcl def to make distinction between old Modules-Tcl and Modules 4+.
Contributor
Author
|
Glad the tests have passed. Please let me know if I should proceed in another way. |
boegel
requested changes
Feb 1, 2018
Member
boegel
left a comment
There was a problem hiding this comment.
Thanks a lot for looking into this @xdelaruelle, much appreciated!
I was trying to find time for this, but didn't manage yet...
| - EB_BOOTSTRAP_SHA256SUM=$(sha256sum $TRAVIS_BUILD_DIR/easybuild/scripts/bootstrap_eb.py | cut -f1 -d' ') | ||
| - EB_BOOTSTRAP_FOUND="$EB_BOOTSTRAP_VERSION $EB_BOOTSTRAP_SHA256SUM" | ||
| - EB_BOOTSTRAP_EXPECTED="20170808.01 7a22faf5ee9d249807fd883e435008fb84c11129425ec09d3cc76918b36ef3d5" | ||
| - EB_BOOTSTRAP_EXPECTED="20180117.01 c3e828769fe30f9e4798972f7ab052632047e5df3224e002d3d2599033678745" |
Member
There was a problem hiding this comment.
@xdelaruelle Let's so with 20180201.01 here to match with the date that is was last updated (you'll need to change it accordingly in easybuild/scripts/bootstrap_eb.py too of course).
Contributor
Author
|
@boegel Change done. Travis check 1648.1 should be re-run as it failed on python-2.6 curl fetch. |
boegel
approved these changes
Feb 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt to fix PR #2370 .