declare support for RPATH linking stable#2409
Merged
wpoely86 merged 1 commit intoeasybuilders:developfrom Feb 23, 2018
Merged
Conversation
Member
Author
|
I marked this as WIP since I'd like to fix #2402 first before declaring this stable (working on it) |
Member
|
👍 |
|
👍 🥇 |
pescobar
approved these changes
Feb 23, 2018
Member
pescobar
left a comment
There was a problem hiding this comment.
LGTM!!!..... since long ago :)
wpoely86
approved these changes
Feb 23, 2018
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the feedback from @jdonners and @pescobar and the discussion we had during the EasyBuild User Meeting in Amsterdam (cfr. https://github.com/easybuilders/easybuild/wiki/3rd-EasyBuild-User-Meeting), the conclusion was that we can declare the RPATH support as stable.
There are a couple of outstanding issues (cfr. #1992), but none of these seem blockers to me; either they are nice-to-have features, or problems specific to a particular software package that can be handled case-by-case.