fix target account for --update-pr in case it's different from GitHub account being used to push branch#2419
Merged
wpoely86 merged 5 commits intoeasybuilders:3.5.xfrom Mar 2, 2018
Conversation
… account being used to push branch
Member
Author
|
tests fail because of SourceForge downtime, I propose we work around this by temporarily disabling those tests, cfr. #2420 |
wpoely86
reviewed
Mar 2, 2018
|
|
||
| if not dry_run: | ||
| _log.debug("Pushing branch '%s' to remote '%s' (%s)", pr_branch, remote_name, github_url) | ||
| _log.debug(push_log_msg) |
Member
There was a problem hiding this comment.
where is the definied? Don't you mean push_branch_mg?
Member
Author
There was a problem hiding this comment.
Ugh, nice catch, thanks.
I fixed this by logging via print_msg (which is covered by the unit tests). The non-dry-run --update-pr is not covered by the tests currently (maybe we should look into mocking the actual push rather than only checking the dry-run...)
boegel
added a commit
to boegel/easybuild-framework
that referenced
this pull request
Mar 2, 2018
wpoely86
approved these changes
Mar 2, 2018
|
|
||
| if not dry_run: | ||
| _log.debug(push_log_msg) | ||
| print_msg(push_branch_msg + '[DRY RUN]', log=_log) |
Member
There was a problem hiding this comment.
space between push_branch_msg and [DRY RUN] ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes
--github-useris not the same as the account/organisation that was used to open a PR, cfr. bug report by @shahzebsiddiqui in #2418...Given it's limited scope & impact I consider this a candidate for a last-minute inclusion in EasyBuild v3.5.2...