avoid that '--inject-checksums' adds lines longer than 120 characters#2434
Merged
boegel merged 5 commits intoeasybuilders:developfrom Mar 13, 2018
Merged
avoid that '--inject-checksums' adds lines longer than 120 characters#2434boegel merged 5 commits intoeasybuilders:developfrom
boegel merged 5 commits intoeasybuilders:developfrom
Conversation
--inject-checksums adds lines longer than 120 characters
…ant for 120 chars limit
Member
extend enhanced `--inject-checksums` to extensions + enhance test
boegel
requested changes
Mar 11, 2018
| "%s'%s'," % (line_indent, checksum), | ||
| ]) | ||
| else: | ||
| exts_list_lines.append(ext_checksum_line) |
Member
There was a problem hiding this comment.
@smoors This diff makes it really stand out that this is a whole bunch of duplicate code, which we should avoid...
We should look into adding an (inner?) function that takes care of this once, for a specified indent level, so we can use it in both situations...
Let me know if you're up for looking into that or not.
Contributor
Author
There was a problem hiding this comment.
ok, I will look into it.
| # reset | ||
| eb.patches = [] | ||
|
|
||
| toy_patch = 'toy-0.0_fix-silly-typo-in-printf-statement.patch' |
Member
There was a problem hiding this comment.
This one should be moved up I guess so toy_patch can also be used above in this test, I overlooked that.
--inject-checksums adds lines longer than 120 characters
boegel
approved these changes
Mar 13, 2018
Member
|
Thanks a lot for looking into this @smoors! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if the line is too long, put the comment in a separate line before the checksum.