Replace raw strings with bytes literal as iterator sentinels in checksum calculation#2446
Merged
boegel merged 1 commit intoeasybuilders:developfrom Mar 16, 2018
Merged
Conversation
Useful for future Python 3 compatibility since raw strings do not seem to work as interator sentinel
Member
|
tests fail, but for a reason unrelated to this PR, follow up in #2447 ... |
Member
|
Based on https://docs.python.org/2/whatsnew/2.6.html#pep-3112-byte-literals and this:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When porting the same construct in Python 3, the use of
r''as iterator sentinel result in an infinite loop.This can be solved by replacing it with a bytes literal.