fix compatibility with Modules v4.1.x#2470
Merged
wpoely86 merged 3 commits intoeasybuilders:developfrom Apr 16, 2018
Merged
Conversation
* don't do error detection on output of 'module show' (just return output) * customise check_module_output for EnvironmentModules class: check for '_mlstatus = False' to detect failing module command
wpoely86
approved these changes
Apr 16, 2018
Contributor
|
Seems ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are required to make EasyBuild fully compatible with Modules v4.1.x (
--modules-tool=EnvironmentModules):when loading non-existing modules, the output of
modulecmd.tcl python loadused to include araise RuntimeErrorstatement which made theloadcommand fail; this is no longer the case in Modules v4.1.x, so we need to customisecheck_module_outputto detect failingmodulecommands based on the presence of_mlstatus = Falsein the outputwe need to disable the output check for
module showbecause of the above, i.e._mlstatus = Falseis also included in the output ofmodule showon a non-existent module@xdelaruelle Please review?