Skip to content

add support to run_cmd to enable streaming output#2476

Merged
wpoely86 merged 4 commits intoeasybuilders:developfrom
boegel:run_cmd_stream
Apr 18, 2018
Merged

add support to run_cmd to enable streaming output#2476
wpoely86 merged 4 commits intoeasybuilders:developfrom
boegel:run_cmd_stream

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 18, 2018

No description provided.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 18, 2018

We can take this a bit further:

  • enable streaming output of commands under eb -l (unless streaming is hard disabled)
  • provide an option to enable streaming output of commands: eb --stream-cmd-output

Thoughts @wpoely86?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 18, 2018

Auto-enabled streaming output under -l (which was more complex than I anticipated, of course it was).

I'm having second thoughts on the --stream-cmd-output option, since we have a lot of "mickey mouse" commands, so I'm not sure it would make much sense to use that.

Comment thread easybuild/tools/run.py Outdated

# auto-enable streaming of command output under --logtostdout/-l, unless it was disabled explicitely
if stream_output is None and build_option('logtostdout'):
_log.info("Auto-enabling streaming output of '%s' command because loggin to stdout is enabled", cmd_msg)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logging

@wpoely86 wpoely86 merged commit 38ac2d8 into easybuilders:develop Apr 18, 2018
@boegel boegel deleted the run_cmd_stream branch April 18, 2018 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants