remove duplicates from --new-pr title#2478
Merged
boegel merged 3 commits intoeasybuilders:developfrom Apr 20, 2018
Merged
Conversation
houndci-bot
reviewed
Apr 20, 2018
| elif file_info['ecs'] and all(file_info['new']) and not deleted_paths: | ||
| # mention software name/version in PR title (only first 3) | ||
| names_and_versions = ["%s v%s" % (ec.name, ec.version) for ec in file_info['ecs']] | ||
| names_and_versions = list(set(names_and_versions)) # remove duplicates |
There was a problem hiding this comment.
at least two spaces before inline comment
boegel
requested changes
Apr 20, 2018
| elif file_info['ecs'] and all(file_info['new']) and not deleted_paths: | ||
| # mention software name/version in PR title (only first 3) | ||
| names_and_versions = ["%s v%s" % (ec.name, ec.version) for ec in file_info['ecs']] | ||
| names_and_versions = list(set(names_and_versions)) # remove duplicates |
Member
There was a problem hiding this comment.
you can use nub for this, from vsc.utils.missing (and then you don't need two lines)
Member
Author
There was a problem hiding this comment.
cool (it is indeed missing from Python :) )
boegel
approved these changes
Apr 20, 2018
Member
|
Going in, thanks @migueldiascosta! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.