add support for passing custom messages on failing sanity check for extensions#2494
Merged
wpoely86 merged 5 commits intoeasybuilders:developfrom May 6, 2018
Merged
Conversation
…ethod in EasyBlock class
wpoely86
approved these changes
May 4, 2018
Member
Author
|
@wpoely86 Good to go? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is motivated by a suggestion by @akesandgren in the context of easybuilders/easybuild-easyblocks#1377, to postpone raising of errors at the end, which helps with limiting a lot of back & forth when the same type of problems arise for multiple extensions.
One issue with moving the download check in easybuilders/easybuild-easyblocks#1377 to the sanity check step is error reporting: the actual cause of the failing sanity check for an extension is hidden higher up in the log.
This is fixed by the (backwards-compatible) changes made in this PR.
For example, with current
developyou would get an error message like:(and then you had to go back in the log to figure out the actual problem)
With these changes, you'll see:
cc @vanzod, @wpoely86