enhance get_module_path function to auto-detect generic vs software-specific easyblock class names#2502
Merged
vanzod merged 2 commits intoeasybuilders:developfrom May 18, 2018
Conversation
…pecific easyblock class names
Member
Author
|
This is a bug fix for a problem reported by @hajgato, cfr. https://gist.github.com/hajgato/1ff71febf642569f575552661f0fecb4. Using this in the easyconfig file: exts_classmap = {'ncdf4': 'RPackage'}The problem was that |
vanzod
reviewed
May 17, 2018
| modulepath = get_module_path(easyblock) | ||
| cls = get_class_for(modulepath, class_name) | ||
| # we might be dealing with a non-generic easyblock, e.g. with --easyblock is used | ||
| # get_module_path figures it out based on specified class name |
Member
There was a problem hiding this comment.
The comment sounds a little obscure to me...
Member
Author
There was a problem hiding this comment.
Yeah, I should probably just drop the comment since get_module_path knows how to handle it? I'll do that.
vanzod
approved these changes
May 17, 2018
Member
vanzod
left a comment
There was a problem hiding this comment.
LGTM, but I'd rather wait on the review of some other maintainer before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.