Skip to content

take into account --filter-deps when re-loading build dependencies in extensions_step#2516

Merged
pescobar merged 1 commit intoeasybuilders:developfrom
boegel:fix_build_dep_exts_step
May 30, 2018
Merged

take into account --filter-deps when re-loading build dependencies in extensions_step#2516
pescobar merged 1 commit intoeasybuilders:developfrom
boegel:fix_build_dep_exts_step

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 30, 2018

alternate/proper fix for bug reported in #2515 (incl. a test that triggers the bug)

cc @zao

@zao
Copy link
Copy Markdown
Contributor

zao commented May 30, 2018

LGTM, works on my module.

@boegel boegel requested a review from pescobar May 30, 2018 13:46
Copy link
Copy Markdown
Member

@pescobar pescobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pescobar pescobar merged commit 59e863f into easybuilders:develop May 30, 2018
@boegel boegel deleted the fix_build_dep_exts_step branch May 30, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants