perform early 'raw' parse of provided easyconfig file to check for syntax error or faulty inputs#2523
Merged
migueldiascosta merged 2 commits intoeasybuilders:developfrom Jun 29, 2018
Conversation
…ntax error or faulty inputs
migueldiascosta
approved these changes
Jun 29, 2018
Member
migueldiascosta
left a comment
There was a problem hiding this comment.
lgtm (and the test passes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As raised in #2383, we currently do a poor job of verifying whether the specified files actually really are easyconfig files before we start processing them...
The fix for this is pretty straightforward: initialize the
EasyConfigParserobject a bit earlier, since that also includes a "raw" parse of the easyconfig file (basically just interpreting the Python code in it).This leads to a clear error when something other than an easyconfig file is passed by accident, for example an HTML page obtained by incorrectly downloading an easyconfig file using
wget: