filter out patched files in test/ in fetch_easyconfigs_from_pr#2547
Merged
akesandgren merged 2 commits intoeasybuilders:developfrom Aug 13, 2018
Merged
filter out patched files in test/ in fetch_easyconfigs_from_pr#2547akesandgren merged 2 commits intoeasybuilders:developfrom
akesandgren merged 2 commits intoeasybuilders:developfrom
Conversation
houndci-bot
reviewed
Aug 11, 2018
| 'animation-2.4-intel-2015b-R-3.2.1.eb', | ||
| ] | ||
| try: | ||
| # PR for rename of ffmpeg to FFmpeg, see https://github.com/easybuilders/easybuild-easyconfigs/pull/2481/files |
There was a problem hiding this comment.
line too long (122 > 120 characters)
a17dab8 to
b1feab3
Compare
Contributor
|
There are now two occurrences of ec_files = gh.fetch_easyconfigs_from_pr( in test_fetch_easyconfigs_from_pr Perhaps it should be rewritten to have a list (hash?) of tuples with PR and list-of-files outside "try" and then a for loop over the PRs. That would make it easier to add a new PR that need special testing in the future. |
Contributor
|
Not exactly what i meant by my comment but easy enough to change if there are more of them in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix,
--from-prfails on PRs that also change files intest/, for example: