skip running of configuration checks while only a single configuration level is taken into account during --show-config#2567
Merged
migueldiascosta merged 5 commits intoeasybuilders:developfrom Sep 11, 2018
Conversation
…n level is taken into account during --show-config
…are configured on different levels
…+ add test to verify modules tool vs syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2564 (cc @omula)
Without this change, the
postprocessmethod was triggered several times when--show-configis used: once for the initial processing of the configuration options, and then a couple times more while while theshow_methodfigures out on which configuration level each setting was defined.This change skips the configuration checks part that was done in
postprocesswhenshow_configis triggered (but the checks are still run during the initial processing of the configuration options).