Skip to content

fix default value for extension checksums to avoid TypeError when indexing a None#2570

Merged
vanzod merged 1 commit intoeasybuilders:developfrom
boegel:bugfix_extension_checksum_patches
Sep 7, 2018
Merged

fix default value for extension checksums to avoid TypeError when indexing a None#2570
vanzod merged 1 commit intoeasybuilders:developfrom
boegel:bugfix_extension_checksum_patches

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 7, 2018

fix for bug introduced in #2561, which is triggered only for an extension that i) has one or more patches, and ii) does not have any checksums

ERROR: Traceback (most recent call last):
  File "/lib/python2.6/site-packages/easybuild_framework-3.6.3.dev0-py2.7.egg/easybuild/main.py", line 126, in build_and_install_software
    (ec_res['success'], app_log, err) = build_and_install_one(ec, init_env)
  File "/lib/python2.7/site-packages/easybuild_framework-3.6.3.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 2831, in build_and_install_one
    result = app.run_all_steps(run_test_cases=run_test_cases)
  File "/lib/python2.7/site-packages/easybuild_framework-3.6.3.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 2747, in run_all_steps
    self.run_step(step_name, step_methods)
  File "/lib/python2.7/site-packages/easybuild_framework-3.6.3.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 2613, in run_step
    step_method(self)()
  File "/lib/python2.7/site-packages/easybuild_framework-3.6.3.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 1651, in fetch_step
    self.exts = self.fetch_extension_sources(skip_checksums=skip_checksums)
  File "/lib/python2.7/site-packages/easybuild_framework-3.6.3.dev0-py2.7.egg/easybuild/framework/easyblock.py", line 542, in fetch_extension_sources
    checksum = self.get_checksum_for(checksums[1:], filename=patch, index=idx)
TypeError: 'NoneType' object has no attribute '__getitem__'

Not sure it's worth puzzling together a test for this...

@boegel boegel added the bug fix label Sep 7, 2018
@boegel boegel added this to the 3.7.0 milestone Sep 7, 2018
@boegel boegel requested a review from vanzod September 7, 2018 19:36
@vanzod vanzod merged commit 8c59b05 into easybuilders:develop Sep 7, 2018
@boegel boegel deleted the bugfix_extension_checksum_patches branch September 7, 2018 21:12
boegel referenced this pull request Sep 11, 2018
@boegel
fix enforcing of checksums for extensions
4b028a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vanzod vanzod vanzod approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @vanzod