Dump a fully parsed easyconfig to the reproducibility dir in all cases #2574
Merged
boegel merged 5 commits intoeasybuilders:developfrom Sep 13, 2018
Merged
Dump a fully parsed easyconfig to the reproducibility dir in all cases #2574boegel merged 5 commits intoeasybuilders:developfrom
boegel merged 5 commits intoeasybuilders:developfrom
Conversation
Member
Author
|
Hmm, not so simple, this is kicking a ton of errors with the tests. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
@ocaisa The only 3 failing tests are the ones that involve |
Member
Author
|
@akesandgren Can you review this, it's a minor change |
boegel
previously requested changes
Sep 12, 2018
Member
boegel
left a comment
There was a problem hiding this comment.
make sense, just some minor suggestions
added 2 commits
September 13, 2018 10:49
boegel
approved these changes
Sep 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2565