Skip to content

determine file_info for all easyconfigs before any actual copying#2604

Merged
boegel merged 2 commits intoeasybuilders:developfrom
migueldiascosta:fix_newpr_labels
Oct 2, 2018
Merged

determine file_info for all easyconfigs before any actual copying#2604
boegel merged 2 commits intoeasybuilders:developfrom
migueldiascosta:fix_newpr_labels

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

fixes an issue with --new-pr where both new and update labels were added (if submitted by a maintainer) when the PR includes multiple versions of the same new software

@migueldiascosta migueldiascosta added this to the 3.7.1 milestone Oct 2, 2018
@migueldiascosta migueldiascosta requested a review from boegel October 2, 2018 03:35
Comment thread easybuild/framework/easyconfig/easyconfig.py Outdated
Comment thread easybuild/framework/easyconfig/easyconfig.py Outdated
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 2, 2018

Looks great, thanks for the fix @migueldiascosta!

@boegel boegel merged commit 723932e into easybuilders:develop Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants