changed easyconfig.update to be able to specify not to allow duplicate values#2657
Merged
boegel merged 7 commits intoeasybuilders:developfrom Nov 14, 2018
Merged
Conversation
houndci-bot
reviewed
Nov 12, 2018
boegel
requested changes
Nov 13, 2018
Member
boegel
left a comment
There was a problem hiding this comment.
Makes sense to add support for this, but it does require a test (and a fix, see other comment) before it can go in...
houndci-bot
reviewed
Nov 14, 2018
Contributor
Author
|
Tests included. Fixed the list problem. |
Contributor
Author
|
Mmmm, @boegel, am I noticing boegelbot acting stupid ? I don't understand the error log. |
Member
|
@mboisson No, it's correctly reporting a failing test. Try running the failing test locally with |
houndci-bot
reviewed
Nov 14, 2018
houndci-bot
reviewed
Nov 14, 2018
Contributor
Author
|
Ok, seems the tests all passed. Ready for another review @boegel |
boegel
approved these changes
Nov 14, 2018
Member
|
lgtm, thanks @mboisson! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address easybuilders/easybuild-easyblocks#1574