make print functions more robust w.r.t. arguments being passed to format the message to be printed#2670
Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom Nov 23, 2018
Conversation
…mat the message to be printed
Member
|
Going in, thanks @boegel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids that
print_warning("Example: %s", foo)gets interpreted asprint_warning("Example: %s", silent=True), but asprint_warning("Example: %s" % foo).Strictly speaking, this is backwards incompatible, but if any code out there now uses
print_warning(msg, arg) it's most likely not working as intended. And usingprint_warningwithsilent=Trueis quite silly anyway, that only makes sense in the tests.