fix logic in robot_find_subtoolchain_for_dep: consider easyconfigs first, before (maybe) considering available modules#2698
Merged
ocaisa merged 2 commits intoeasybuilders:3.8.xfrom Dec 18, 2018
Conversation
…rst, before (maybe) considering available modules
ocaisa
approved these changes
Dec 17, 2018
Member
ocaisa
left a comment
There was a problem hiding this comment.
LGTM...is there a way we can add a test for this?
…able modules, unless --use-existing-modules is enabled
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a backwards-incompatible change that was introduced in #2690 .
The logic in
robot_find_minimal_toolchain_of_dependencywas such that the available easyconfig files determined which subtoolchain was used for each dependency, while now inrobot_find_subtoolchain_for_depit is available modules first and only then available easyconfig files.This creates problems in situations where there are multiple easyconfig files available with different (sub)toolchains that can be used to resolve a dependency, and when only some of them are installed.
For example, if
zlibis installed withGCCcoreas toolchain, this will determine the subtoolchain used forzlibthat's listed as a dependency. When laterzlibis also installed withfoss, the selected toolchain for azlibdependency changes whenfossis used as a toolchain, which results in a toolchain conflict onzlib.This problem surfaced during the regression test for EasyBuild v3.8.0, in particular for easyconfigs used the
foss/2016*andintel/2016*toolchains (which is when we started pushing "down" dependencies likezlibto the compiler-only subtoolchain rather than the full toolchain).