fix import with Python 3 for easybuild.tools.* modules and easybuild.main#2719
Merged
wpoely86 merged 10 commits intoeasybuilders:4.xfrom Jan 14, 2019
Merged
fix import with Python 3 for easybuild.tools.* modules and easybuild.main#2719wpoely86 merged 10 commits intoeasybuilders:4.xfrom
wpoely86 merged 10 commits intoeasybuilders:4.xfrom
Conversation
…syconfig.types to fix NameError on import of some easybuild.tools.* modules with Python 3
…ild.tools.ordereddict as fallback for Python 2.6
…d in that context)
… in easybuild.tools.options
… in easybuild.main + test importing easybuild.main with Python 3
wpoely86
reviewed
Jan 13, 2019
| # method definition as it is in logging, can't change this | ||
| # pylint: disable=unused-argument | ||
| def makeRecord(self, name, level, pathname, lineno, msg, args, excinfo, func=None, extra=None): | ||
| def makeRecord(self, name, level, pathname, lineno, msg, args, excinfo, func=None, extra=None, sinfo=None): |
Member
There was a problem hiding this comment.
some documentation on the arguments wouldn't go amiss
Member
Author
There was a problem hiding this comment.
Yeah, I agree, but the Python documentation itself is rather light on this too...
This is only used internally in fancylogger, I'd rather not spend too much time on this.
Member
Author
There was a problem hiding this comment.
| url_fd = urllib2.urlopen(url_req, timeout=timeout) | ||
| if used_urllib is std_urllib: | ||
| # urllib2 (Python 2) / urllib.request (Python 3) does the right thing for http proxy setups, | ||
| # urllib does not! |
Member
There was a problem hiding this comment.
is this still relevant? Do we use urllib anywhere?
Member
Author
There was a problem hiding this comment.
No, but we used to, and I guess the comment serves as a reminder why we use urllib2 rather than urllib, doesn't hurt to keep it there imho.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.