Skip to content

consistently use 'string_type' from easybuild.tools.py2vs3 rather than 'basestring'#2721

Merged
migueldiascosta merged 2 commits intoeasybuilders:4.xfrom
boegel:no_more_basestring
Jan 15, 2019
Merged

consistently use 'string_type' from easybuild.tools.py2vs3 rather than 'basestring'#2721
migueldiascosta merged 2 commits intoeasybuilders:4.xfrom
boegel:no_more_basestring

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jan 14, 2019

No description provided.

@boegel boegel added the python3 Python 3 compatibility label Jan 14, 2019
@boegel boegel added this to the 4.0 milestone Jan 14, 2019
Comment thread test/framework/systemtools.py Outdated
@boegel boegel force-pushed the no_more_basestring branch from 55c766d to 6f16ffd Compare January 14, 2019 21:43
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit 5836843 into easybuilders:4.x Jan 15, 2019
@boegel boegel deleted the no_more_basestring branch January 15, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python3 Python 3 compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants