Skip to content

Sort available version list when selecting/generating easyconfig#2732

Merged
boegel merged 8 commits intoeasybuilders:developfrom
ocaisa:pick_version_bugfix
Apr 8, 2019
Merged

Sort available version list when selecting/generating easyconfig#2732
boegel merged 8 commits intoeasybuilders:developfrom
ocaisa:pick_version_bugfix

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Jan 21, 2019

Fix for #2731

Comment thread easybuild/framework/easyconfig/tweak.py
@easybuilders easybuilders deleted a comment from boegelbot Jan 24, 2019
@ocaisa ocaisa requested a review from boegel January 24, 2019 12:50
@boegel boegel added this to the next release (3.8.2) milestone Feb 23, 2019
@damianam
Copy link
Copy Markdown
Member

This lgtm. But I haven't tested it. @ocaisa, @jose-d can you confirm that this change indeed fixes it?

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 8, 2019

I've reproduced the bug being fixed here in the tests (and fixed another issue in pick_version along the way), please take a look at these additional changes @ocaisa: ocaisa#43

add tests to capture fixed bugs in pick_version and --software (+ fix one more bug)
Comment thread test/framework/options.py Outdated
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 8, 2019

Going in, thanks for figuring out the fix @ocaisa!

@boegel boegel merged commit 5713368 into easybuilders:develop Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants