Replace deps by hidden deps instead of removing them from the lists.#2748
Merged
boegel merged 6 commits intoeasybuilders:developfrom Feb 8, 2019
Merged
Conversation
This a cleanup so that hidden deps do not need to be re-added when dumping the easyconfig. The build only needs to consider builddependencies and dependencies, with integrated hidden dependencies.
houndci-bot
reviewed
Feb 1, 2019
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
./easybuild/framework/easyconfig/easyconfig.py:200:-470: W605 invalid escape ...
./easybuild/framework/easyconfig/easyconfig.py:200:-470: W605 invalid escape sequence '\ ' ./easybuild/framework/easyconfig/easyconfig.py:200:-461: W605 invalid escape sequence '\ ' ./easybuild/framework/easyconfig/easyconfig.py:200:-346: W605 invalid escape sequence '\ ' ./easybuild/framework/easyconfig/easyconfig.py:200:-269: W605 invalid escape sequence '\ '
houndci-bot
reviewed
Feb 1, 2019
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
./easybuild/framework/easyconfig/easyconfig.py:200:-470: W605 invalid escape ...
./easybuild/framework/easyconfig/easyconfig.py:200:-470: W605 invalid escape sequence '\ ' ./easybuild/framework/easyconfig/easyconfig.py:200:-461: W605 invalid escape sequence '\ ' ./easybuild/framework/easyconfig/easyconfig.py:200:-346: W605 invalid escape sequence '\ ' ./easybuild/framework/easyconfig/easyconfig.py:200:-269: W605 invalid escape sequence '\ '
houndci-bot
reviewed
Feb 1, 2019
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
./easybuild/framework/easyconfig/easyconfig.py:200:-470: W605 invalid escape ...
./easybuild/framework/easyconfig/easyconfig.py:200:-470: W605 invalid escape sequence '\ ' ./easybuild/framework/easyconfig/easyconfig.py:200:-461: W605 invalid escape sequence '\ ' ./easybuild/framework/easyconfig/easyconfig.py:200:-346: W605 invalid escape sequence '\ ' ./easybuild/framework/easyconfig/easyconfig.py:200:-269: W605 invalid escape sequence '\ '
houndci-bot
reviewed
Feb 1, 2019
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
./easybuild/framework/easyconfig/easyconfig.py:200:-470: W605 invalid escape ...
./easybuild/framework/easyconfig/easyconfig.py:200:-470: W605 invalid escape sequence '\ ' ./easybuild/framework/easyconfig/easyconfig.py:200:-461: W605 invalid escape sequence '\ ' ./easybuild/framework/easyconfig/easyconfig.py:200:-346: W605 invalid escape sequence '\ ' ./easybuild/framework/easyconfig/easyconfig.py:200:-269: W605 invalid escape sequence '\ '
boegel
requested changes
Feb 7, 2019
It now goes through a plain loop without list comprehensions and code duplication. The (build)dependencies are now modified in-place instead of creating new lists.
boegel
requested changes
Feb 8, 2019
houndci-bot
reviewed
Feb 8, 2019
8fb9b12 to
975a9be
Compare
boegel
approved these changes
Feb 8, 2019
Member
|
Thanks for the effort @bartoldeman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a cleanup so that hidden deps do not need to be re-added when
dumping the easyconfig. The build only needs to consider
builddependencies and dependencies, with integrated hidden
dependencies.