ensure non-zero exit code for all test subsuites (+ fix trivial style issues)#2773
Merged
akesandgren merged 3 commits intoeasybuilders:developfrom Feb 16, 2019
Merged
Conversation
houndci-bot
reviewed
Feb 16, 2019
houndci-bot
reviewed
Feb 16, 2019
akesandgren
reviewed
Feb 16, 2019
akesandgren
reviewed
Feb 16, 2019
Contributor
|
Going in, thanks @boegel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running a test subsuite always results in a zero exit code (suggesting success), regardless of whether any tests failed or not, which is stupid/annoying.
I fixed a whole bunch of style issues in the test modules while I was fixing this, which makes this PR look scary, but the changes are all trivial...
No tests were harmed in the process, and all changes are limited to
test/*