fix running of 'easyconfigparser' and 'format_convert' test suites with Python 3#2778
Merged
bartoldeman merged 1 commit intoeasybuilders:4.xfrom Feb 21, 2019
Merged
Conversation
bartoldeman
approved these changes
Feb 21, 2019
Contributor
bartoldeman
left a comment
There was a problem hiding this comment.
Ah metaclasses, so much fun there is to be had. I don't completely understand it at first (it's been a long time since I was so deeply into Python classes), but it looks ok, so I will approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly about fixing the
Wrapperclass so it also works with Python 3, but I also stripped out a bunch of stuff that we no longer use (seePatch*andListOfStrings& co) since some of those tests were failing on top of Python 3.It was non-trivial to fix those tests, and there's little point anyway in fixing something that is no longer used...
The
Wrapperclass is still used for theDependencyclass (viaConvert), so that part is definitely still relevant (for now...).