Skip to content

automatically enable --ignore-osdeps when using --preview-pr#2799

Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:preview_pr_ignore_osdeps
Mar 6, 2019
Merged

automatically enable --ignore-osdeps when using --preview-pr#2799
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:preview_pr_ignore_osdeps

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 6, 2019

Also done for --new-pr and --update-pr, makes perfect sense to also do it for --preview-pr...

@boegel boegel added this to the next release (3.8.2) milestone Mar 6, 2019
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit 97ffce7 into easybuilders:develop Mar 6, 2019
@boegel boegel deleted the preview_pr_ignore_osdeps branch March 6, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants