Skip to content

fix test_import_available_modules on top of Python 3.7 by making sure sys.path has an empty entry#2800

Merged
akesandgren merged 3 commits intoeasybuilders:4.xfrom
boegel:fix_test_import_available_modules_py37
Mar 7, 2019
Merged

fix test_import_available_modules on top of Python 3.7 by making sure sys.path has an empty entry#2800
akesandgren merged 3 commits intoeasybuilders:4.xfrom
boegel:fix_test_import_available_modules_py37

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 6, 2019

No description provided.

@boegel boegel added bug fix python3 Python 3 compatibility labels Mar 6, 2019
@boegel boegel added this to the 4.0 milestone Mar 6, 2019
@vanzod
Copy link
Copy Markdown
Member

vanzod commented Mar 6, 2019

@boegel You need to exclude GC3Pie for Python 3.7 too

@easybuilders easybuilders deleted a comment from boegelbot Mar 7, 2019
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 11ec6a4 into easybuilders:4.x Mar 7, 2019
@boegel boegel deleted the fix_test_import_available_modules_py37 branch March 7, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix python3 Python 3 compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants