ensure correct value type in data field of Request object in Python 2/3#2806
Merged
wpoely86 merged 2 commits intoeasybuilders:4.xfrom Mar 12, 2019
Merged
ensure correct value type in data field of Request object in Python 2/3#2806wpoely86 merged 2 commits intoeasybuilders:4.xfrom
wpoely86 merged 2 commits intoeasybuilders:4.xfrom
Conversation
wpoely86
reviewed
Mar 11, 2019
|
|
||
| status, body = client.repos['hpcugent']['testrepository'].contents.a_directory['a_file.txt'].get() | ||
| self.assertEqual(status, 200) | ||
| # dGhpcyBpcyBhIGxpbmUgb2YgdGV4dAo= == 'this is a line of text' in base64 encoding |
Member
There was a problem hiding this comment.
why don't you encode this on the fly instead of this comment?
Member
Author
There was a problem hiding this comment.
I stole this from the vsc-base checks, I have to admit I don't know why it was done like this.
Will try and encode on the fly...
wpoely86
approved these changes
Mar 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, the added test fails as below when using Python 3.
This is relevant for features like
--upload-test-report.