iterate over subdirectories in order in find_egg_dir_for of bootstrap script, to ensure oldest vsc-install is picked#2819
Merged
ocaisa merged 1 commit intoeasybuilders:developfrom Mar 22, 2019
Conversation
… script, to ensure oldest vsc-install is picked
ocaisa
approved these changes
Mar 22, 2019
This was referenced Mar 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing of the bootstrap script is currently failing with (only) Python 2.7 because of a combo of a silly bug in the bootstrap script and the latest
vsc-installchecked into themasterbranch on GitHub (0.12.2) not being released yet on PyPI...Two versions of
vsc-installare being installed currently due to thevsc-install < 0.11.4workaround that was added in #2717:vsc-install-0.11.3and whichever is the latest version (which gets pulled in viavsc-base).The 0.11.3 is supposed to take the upper hand, but that's currently not always the case apparently...
Depending on the order in which
vsc-installinstallations are considered in thefind_egg_dir_forin the bootstrap script, one or the other may be picked up. If the latest version is picked up, we're in trouble, especially if that version is not available onPyPIyet, since that results in an error like:The error has been improved here as well, to mention the pattern being searched for:
Making sure that
find_egg_dir_forconsiders thevsc-installinstallation in order (oldest first) fixes the problem.In Python 2.7,
os.listdirhas a different default order than in Python 2.6, which explains why the problem only occurs there (at least in Travis).