add support for loading first version listed in multi_deps by default in generated module file#2828
Conversation
…e names to use in guarded load statement
… in generated module file
…e test_toy_multi_deps check for it by making Lmod fail on same-name auto-swap)
…s in multi_deps context
…ensions in multi_deps context
|
I ran into an issue from this PR. I found For the example of a python build, my expectation would be that yields not The latter is just asking for trouble and inconsistent results over time in my opinion, as you will end up having different modules loading different "default" versions of python. |
|
If one wants to limit to the known versions, it could be |
|
@mboisson Leaving it up to the actual default is equally problematic, since that tends to change over time (and it's outside of the control of EasyBuild)... The naming may be a bit unfortunate, but the help message is pretty clear: |
|
I can understand the rationale, but I disagree with it. We will probably always disable the automatic loading. In my opinion, setting a default should not be something that requires hard coding in a module, and réinstallation to change the default. There are mechanism in module systems, like deprecation, hiding, default versions, especially made to handle this.
Anyway, I’m happy that there is a flag to disable this. I would probably be slightly happier if it were a global config flag rather than an easy config specific flag.... actually, does it exist as a global flag that we can turn off ?
…
On Aug 7, 2019 at 4:36 PM, <Kenneth Hoste ***@***.***)> wrote:
@mboisson (https://github.com/mboisson) Leaving it up to the actual default is equally problematic, since that tends to change over time (and it's outside of the control of EasyBuild)...
The naming may be a bit unfortunate, but the help message is pretty clear:
$ eb -a | grep multi_deps_load_default multi_deps_load_default Load module for first version listed in multi_deps by default [default: True]
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#2828?email_source=notifications&email_token=ABZKY2SXI6H737YOCOLSSKLQDMW6DA5CNFSM4HDJ74J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZUJIY#issuecomment-519259299), or mute the thread (https://github.com/notifications/unsubscribe-auth/ABZKY2VGC4GHVC5PBLPIUPDQDMW6DANCNFSM4HDJ74JQ).
|
|
The other problem is the inconsistency that it creates. Lmod already shows what is the default version of a module, and now the module comes and hard code a potentially different version. That is just confusing. I would like to even remove the mention in the help message that there is a specific default version, but it seems that the flag to disable the loading of defaults does not remove that mention in the module help.
…
On Aug 7, 2019 at 5:03 PM, <Maxime Boissonneault ***@***.***)> wrote:
I can understand the rationale, but I disagree with it. We will probably always disable the automatic loading. In my opinion, setting a default should not be something that requires hard coding in a module, and réinstallation to change the default. There are mechanism in module systems, like deprecation, hiding, default versions, especially made to handle this.
Anyway, I’m happy that there is a flag to disable this. I would probably be slightly happier if it were a global config flag rather than an easy config specific flag.... actually, does it exist as a global flag that we can turn off ?
>
> On Aug 7, 2019 at 4:36 PM, <Kenneth Hoste ***@***.***)> wrote:
>
>
>
>
> @mboisson (https://github.com/mboisson) Leaving it up to the actual default is equally problematic, since that tends to change over time (and it's outside of the control of EasyBuild)...
>
>
>
> The naming may be a bit unfortunate, but the help message is pretty clear:
>
>
> $ eb -a | grep multi_deps_load_default multi_deps_load_default Load module for first version listed in multi_deps by default [default: True]
>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub (#2828?email_source=notifications&email_token=ABZKY2SXI6H737YOCOLSSKLQDMW6DA5CNFSM4HDJ74J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZUJIY#issuecomment-519259299), or mute the thread (https://github.com/notifications/unsubscribe-auth/ABZKY2VGC4GHVC5PBLPIUPDQDMW6DANCNFSM4HDJ74JQ).
>
>
>
|
|
There's no global flag to turn this off, but we can certainly consider adding that. The fact that the mention in module help stays there even if this is disabled sounds like a bug... Please open separate issues on both to follow up (comments in a merged PR make good follow-up difficult...). |
No description provided.