Skip to content

update template values after updating iterative easyconfig parameters#2854

Merged
akesandgren merged 2 commits intoeasybuilders:developfrom
boegel:fix_multi_deps_templates
May 2, 2019
Merged

update template values after updating iterative easyconfig parameters#2854
akesandgren merged 2 commits intoeasybuilders:developfrom
boegel:fix_multi_deps_templates

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 1, 2019

This solves a bug reported by @Micket, where templates like %(pyver)s were not getting resolved in builddependencies when using multi_deps.

Example use case:

multi_deps = {'Python': ['3.7.2', '2.7.15']}
builddependencies = [('SWIG', '3.0.12', '-Python-%(pyver)s')]

SWIG can't be installed multi-Python via multi_deps since it's not a traditional Python package.

@boegel boegel added the bug fix label May 1, 2019
@boegel boegel added this to the next release (3.9.1) milestone May 1, 2019
Comment thread test/framework/easyconfig.py Outdated
Comment thread test/framework/easyconfig.py Outdated
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 1168040 into easybuilders:develop May 2, 2019
@boegel boegel deleted the fix_multi_deps_templates branch May 2, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants