deprecate useless 'skip_lower' named argument in template_constant_dict, always define *lower templates#2856
Merged
akesandgren merged 2 commits intoeasybuilders:developfrom May 6, 2019
Conversation
…ct, always define *lower templates
ocaisa
previously approved these changes
May 3, 2019
akesandgren
reviewed
May 6, 2019
Contributor
|
Going in, thanks @boegel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason unclear to me the template values are generated in two passes: once without
%(namelower)s, and then again with%(namelower)s(where the set of template values is mostly the same, except for%(namelower)sand%(nameletterlower)s).This was introduced a long time ago as a part of a big refactor in #526, but I don't see a reason (anymore) for this.
Besides the double work being done without good reason, having the
skip_lowernamed argument that is enabled by default in thetemplate_constant_dictfunction is confusing, it leads to bugs wheretemplate_constant_dictis called withoutskip_lower=Falsewhich results in the%(namelower)stemplate not getting resolved (cfr. #2852 (comment))