Skip to content

inject dependencies specified via multi_deps before normal build dependencies#2861

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:multi_deps_builddeps_order
May 6, 2019
Merged

inject dependencies specified via multi_deps before normal build dependencies#2861
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:multi_deps_builddeps_order

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 6, 2019

Dependencies listed via multi_deps(for example Python) must be prepended to the list of build dependencies, to ensure that they get loaded first when setting up the build environment in the prepare step.

This is important if any of the build dependencies were also installed using multi_deps.

Example: installing h5py with Python 3.7.2 + 2.7.15 which requires (the Python bindings of) pkgconfig as a build dependency, which was also installed via multi_deps to support both Python 3.7.2 & 2.7.15; cfr. easybuilders/easybuild-easyconfigs#8135

…ndencies (which may be multi_deps installations by themselves)
@boegel boegel added this to the next release (3.9.1) milestone May 6, 2019
@boegel boegel requested a review from akesandgren May 6, 2019 12:02
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 250ad74 into easybuilders:develop May 6, 2019
@boegel boegel deleted the multi_deps_builddeps_order branch May 6, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants