Skip to content

bump iteration index counter at the correct time#2886

Merged
vanzod merged 4 commits intoeasybuilders:developfrom
ocaisa:curr_idx
May 17, 2019
Merged

bump iteration index counter at the correct time#2886
vanzod merged 4 commits intoeasybuilders:developfrom
ocaisa:curr_idx

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented May 17, 2019

Fixes #2885

@boegel
Copy link
Copy Markdown
Member

boegel commented May 17, 2019

@ocaisa Hmm, I'm not sure this is the best approach, I feel it can lead to continued confusion because we have two variables with different semantics.

Moreover, since self.iter_idx will be >=1 after the first call to handle_iterate_opts, the if self.iter_idx > 0 in prepare_step is wrong (but it doesn't do much harm, it just resets the toolchain also during the first iteration).

Maybe the best way is to have a next_iter method that (currently) simply bumps self.iter_idx (and spits out a log message than the iteration is done)?

bump iteration index counter at the correct time rather than introducing another iteration index counter
@boegel boegel added this to the 3.9.1 milestone May 17, 2019
@boegel boegel changed the title Add an iteration reference value for use by easyblocks bump iteration index counter at the correct time May 17, 2019
@vanzod vanzod merged commit 15f7fec into easybuilders:develop May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants