bump iteration index counter at the correct time#2886
Merged
vanzod merged 4 commits intoeasybuilders:developfrom May 17, 2019
Merged
bump iteration index counter at the correct time#2886vanzod merged 4 commits intoeasybuilders:developfrom
vanzod merged 4 commits intoeasybuilders:developfrom
Conversation
ocaisa
pushed a commit
to ocaisa/easybuild-easyblocks
that referenced
this pull request
May 17, 2019
Member
|
@ocaisa Hmm, I'm not sure this is the best approach, I feel it can lead to continued confusion because we have two variables with different semantics. Moreover, since Maybe the best way is to have a |
…ing another iteration index counter
bump iteration index counter at the correct time rather than introducing another iteration index counter
boegel
approved these changes
May 17, 2019
vanzod
approved these changes
May 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2885