don't specify --ntasks-per-node when submitting Slurm jobs#2887
Merged
ocaisa merged 1 commit intoeasybuilders:developfrom May 18, 2019
Merged
don't specify --ntasks-per-node when submitting Slurm jobs#2887ocaisa merged 1 commit intoeasybuilders:developfrom
ocaisa merged 1 commit intoeasybuilders:developfrom
Conversation
ocaisa
approved these changes
May 18, 2019
Contributor
|
Yes, I agree that --ntasks-per-node should not be used. But nor should --nodes be, you should only use -n and -c and let the batch system take care of the rest. |
Member
|
Not really, you need all the cores on the same node, |
Contributor
|
Yes, but mpi tests don't. And it's up to the user to specify sane things. EB shouldn't get in my way... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, jobs to a
Slurmbackend are being submitted with "sbatch --nodes 1 --ntasks 5 --ntasks-per-node 5" when "eb --job --job-cores 5" is used.That works fine, until you change your mind after the jobs were submitted and you want to increase the number of cores using
scontrol update job=<jobid> NumTasks=10 NumCPUS=10.The
--ntasks-per-node 5that was used at submission time can not be changed afterwards, and thus it prevents you from increasing the number of requested cores for that job (if you do try to increase the number of cores/tasks, the job gets stuck due toBadConstraints).I see no need for using
--ntasks-per-nodeat all, so let's just remove it...Afaik, this shouldn't cause any problems.