add support for specifying non-image based bootstrap agents in Singularity container recipes via --container-base-config#2903
Merged
wpoely86 merged 3 commits intoeasybuilders:developfrom May 26, 2019
Conversation
…arity container recipes in --container-base-config
wpoely86
reviewed
May 25, 2019
wpoely86
approved these changes
May 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things that work now that did not before:
This is only partially useful for now, since the assumption is still that EasyBuild is installed in the container image (which it won't be if you start from a minimal OS), along with
pip, Lmod, etc., and that aneasybuilduser exists that has write access to/app/and/scratch/.I plan to fix that in a follow-up PR, but I prefer keeping the scope of PRs limited to make them easier to review/merge.
This fixes #2901 along the way too (cc @ArangoGutierrez):
When an existing image is being pulled from a repository like Singularity Hub (
shub), Sylabs Container Library (library) or Docker Hub (docker), or if a local container image (localimage) is used as base, the assumptions w.r.t. EasyBuild, Lmod and theeasybuilduser are probably going to stand (for now)...