Skip to content

fix crash on iterated installation when using Cray toolchains#2914

Merged
boegel merged 5 commits intoeasybuilders:developfrom
ocaisa:compiler_reset_bug
Jun 6, 2019
Merged

fix crash on iterated installation when using Cray toolchains#2914
boegel merged 5 commits intoeasybuilders:developfrom
ocaisa:compiler_reset_bug

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Jun 6, 2019

Fixes #2911

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Jun 6, 2019

I've trivialised the necessary change. By adding an empty element to the list, resetting the toolchain between iterations has no impact on the build environment.

Before this change it seemed like the zero element was either being cleaned out or somehow being evaluated as equivalent to None.

@ocaisa ocaisa changed the title Skip blas and lapack var setting when using Cray libsci Add empty element to blas vars for libsci Jun 6, 2019
@gppezzi
Copy link
Copy Markdown
Contributor

gppezzi commented Jun 6, 2019

I confirm that this fix solves our problem (#2911).

Thanks @ocaisa !

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 6, 2019

@ocaisa Is there any way in which we could enhance the tests to catch this issue (and prevent from re-introducing it)?

@boegel boegel added the bug fix label Jun 6, 2019
@boegel boegel added this to the next release (3.9.2) milestone Jun 6, 2019
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Jun 6, 2019

@boegel I guess we could check that the toolchain is reset-able...I'll see how hard that is.

Comment thread test/framework/toolchain.py
@boegel boegel changed the title Add empty element to blas vars for libsci fix crash on iterated installation when using Cray toolchains Jun 6, 2019
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for figuring this out @ocaisa!

@boegel boegel merged commit d314b1e into easybuilders:develop Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants