fix crash on iterated installation when using Cray toolchains#2914
Merged
boegel merged 5 commits intoeasybuilders:developfrom Jun 6, 2019
Merged
fix crash on iterated installation when using Cray toolchains#2914boegel merged 5 commits intoeasybuilders:developfrom
boegel merged 5 commits intoeasybuilders:developfrom
Conversation
Member
Author
|
I've trivialised the necessary change. By adding an empty element to the list, resetting the toolchain between iterations has no impact on the build environment. Before this change it seemed like the zero element was either being cleaned out or somehow being evaluated as equivalent to |
Contributor
Member
|
@ocaisa Is there any way in which we could enhance the tests to catch this issue (and prevent from re-introducing it)? |
Member
Author
|
@boegel I guess we could check that the toolchain is |
ocaisa
commented
Jun 6, 2019
… + mention issue in comment
…value of $LIBBLAS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2911