Skip to content

disable checking of read/exec permissions when checking for availability of 'sudo' command#2918

Merged
wpoely86 merged 3 commits intoeasybuilders:developfrom
boegel:containers_sudo_check_fix
Jun 8, 2019
Merged

disable checking of read/exec permissions when checking for availability of 'sudo' command#2918
wpoely86 merged 3 commits intoeasybuilders:developfrom
boegel:containers_sudo_check_fix

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 8, 2019

On CentOS7:

$ which sudo
/usr/bin/sudo
$ file /usr/bin/sudo
/usr/bin/sudo: setuid executable, regular file, no read permission
$ ls -l /usr/bin/sudo
---s--x--x. 1 root root 147392 Oct 31  2018 /usr/bin/sudo

Without this, using --container-build-image fails with:

ERROR: sudo not found on your system

@boegel boegel added the bug fix label Jun 8, 2019
@boegel boegel added this to the next release (3.9.2) milestone Jun 8, 2019
vanzod
vanzod previously approved these changes Jun 8, 2019
View reviewed changes
akesandgren
akesandgren previously approved these changes Jun 8, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vanzod
vanzod previously approved these changes Jun 8, 2019
View reviewed changes
boegel added a commit to boegel/easybuild-framework that referenced this pull request Jun 8, 2019
@boegel
add PR easybuilders#2918 to EasyBuild v3.9.2 release notes
939c31d
wpoely86
wpoely86 reviewed Jun 8, 2019
View reviewed changes
Comment thread easybuild/tools/filetools.py
@boegel boegel dismissed stale reviews from vanzod and akesandgren via 48f0323 June 8, 2019 16:32
@wpoely86 wpoely86 merged commit d8405a1 into easybuilders:develop Jun 8, 2019
@boegel boegel deleted the containers_sudo_check_fix branch June 8, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpoely86 wpoely86 wpoely86 approved these changes

@akesandgren akesandgren akesandgren left review comments

@vanzod vanzod vanzod left review comments

Assignees

No one assigned

Labels

bug fix containers

Projects

None yet

Milestone

3.9.2

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @akesandgren @wpoely86 @vanzod