enhance 'completed' message with how much time was needed the installation#2956
Merged
wpoely86 merged 3 commits intoeasybuilders:developfrom Aug 14, 2019
Merged
enhance 'completed' message with how much time was needed the installation#2956wpoely86 merged 3 commits intoeasybuilders:developfrom
wpoely86 merged 3 commits intoeasybuilders:developfrom
Conversation
…ython 2.6; check value type passed to time2str
houndci-bot
reviewed
Aug 6, 2019
houndci-bot
reviewed
Aug 6, 2019
wpoely86
approved these changes
Aug 14, 2019
| if not isinstance(delta, datetime.timedelta): | ||
| raise EasyBuildError("Incorrect value type provided to time2str, should be datetime.timedelta: %s", type(delta)) | ||
|
|
||
| delta_secs = delta.days * 3600 * 24 + delta.seconds + delta.microseconds / 10**6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
now:
For long-running builds the time will be shown in minutes/seconds or hours/minutes/seconds (not days), see example outputs in tests.