HMNS: Define mapping for iccifort->intel for iccifort compiler-only.#2996
Merged
boegel merged 3 commits intoeasybuilders:developfrom Sep 10, 2019
Merged
HMNS: Define mapping for iccifort->intel for iccifort compiler-only.#2996boegel merged 3 commits intoeasybuilders:developfrom
boegel merged 3 commits intoeasybuilders:developfrom
Conversation
Contributor
Author
|
test to come... |
The HMNS plus supporting code was still assuming in two places that icc and ifort are separate. This is now eliminated.
houndci-bot
reviewed
Sep 10, 2019
| 'ifort-2016.1.150.eb': ('ifort/2016.1.150', 'Core', ['Compiler/intel/2016.1.150'], | ||
| ['Compiler/intel/2016.1.150'], ['Core']), | ||
| 'iccifort-2016.1.150.eb': ('iccifort/2016.1.150', 'Core', ['Compiler/intel/2016.1.150'], | ||
| ['Compiler/intel/2016.1.150'], ['Core']), |
There was a problem hiding this comment.
continuation line under-indented for visual indent
houndci-bot
reviewed
Sep 10, 2019
| 'ifort-2016.1.150.eb': ('ifort/2016.1.150', 'Core', ['Compiler/intel/2016.1.150'], | ||
| ['Compiler/intel/2016.1.150'], ['Core']), | ||
| 'iccifort-2016.1.150.eb': ('iccifort/2016.1.150', 'Core', ['Compiler/intel/2016.1.150'], | ||
| ['Compiler/intel/2016.1.150'], ['Core']), |
There was a problem hiding this comment.
continuation line under-indented for visual indent
Contributor
Author
|
I added the bug fix label since the HMNS was broken for using iccifort compiler-only as a toolchain (it complained about the 'icc' component missing). |
boegel
approved these changes
Sep 10, 2019
Member
|
Thanks a lot for tackling this @bartoldeman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.