Skip to content

Make installation independent of module naming scheme by default#2999

Merged
wpoely86 merged 5 commits intoeasybuilders:developfrom
ocaisa:installdir_default
Sep 17, 2019
Merged

Make installation independent of module naming scheme by default#2999
wpoely86 merged 5 commits intoeasybuilders:developfrom
ocaisa:installdir_default

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Sep 13, 2019

No description provided.

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Sep 13, 2019

Setting this as a default will open the door to us allowing people to "replay" module creation using different MNS's.

@boegel boegel added this to the 4.0.0 milestone Sep 13, 2019
@boegel boegel added the change label Sep 13, 2019
@easybuilders easybuilders deleted a comment from boegelbot Sep 13, 2019
…ng --fixen-installdir-naming-scheme by default
@easybuilders easybuilders deleted a comment from boegelbot Sep 14, 2019
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Sep 14, 2019

It's now 99% your PR, does that mean I can approve it?

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 14, 2019

@ocaisa I don't think you can approve your own PR.

Fair game is to get a 3rd party to review this...

@wpoely86 wpoely86 merged commit c9f5370 into easybuilders:develop Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants