Skip to content

print warning when 'eb' command is not found in $PATH and for empty robot search path#3006

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:warn_empty_robot_paths
Sep 16, 2019
Merged

print warning when 'eb' command is not found in $PATH and for empty robot search path#3006
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:warn_empty_robot_paths

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 15, 2019

Using EasyBuild with an empty robot search path is likely to end in tears, so we should print a warning for it.

The location of the eb command is used as a fallback to determine the default robot search path, and having a setup where EasyBuild works (when run with python -m easybuild.main) without having the eb command available is weird, so deserves a warning as well.

@boegel boegel added the change label Sep 15, 2019
@boegel boegel added this to the 4.0.0 milestone Sep 15, 2019
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 6a22331 into easybuilders:develop Sep 16, 2019
@boegel boegel deleted the warn_empty_robot_paths branch September 16, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants