Skip to content

change order of 'python*' commands considered by 'eb' command: python, python3, python2#3007

Merged
bartoldeman merged 1 commit intoeasybuilders:developfrom
boegel:eb_python_order
Sep 16, 2019
Merged

change order of 'python*' commands considered by 'eb' command: python, python3, python2#3007
bartoldeman merged 1 commit intoeasybuilders:developfrom
boegel:eb_python_order

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 16, 2019

  • python is considered first since that's assumed to be the preferred Python version
  • python3 is considered before python2 since Python 2 is EOL on Dec 31st 2019

@boegel boegel added the change label Sep 16, 2019
@boegel boegel added this to the 4.0.0 milestone Sep 16, 2019
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wpoely86
Copy link
Copy Markdown
Member

What's the way this is handle in Debian/Ubuntu? With RHEL 8 you have to use either python2 or python3. I guess Debian handles this with update-alternatives which changes to what the python commands points to?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 16, 2019

Maybe @akesandgren or @vanzod can pitch in on @wpoely86's question?

In any case, you can always use $EB_PYTHON to specify which Python command eb should use...

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Sep 16, 2019

On Ubuntu 18.04 we have:
ls -l /usr/bin/python
lrwxrwxrwx 1 root root 9 Nov 24 2017 /usr/bin/python -> python2.7

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel requested a review from bartoldeman September 16, 2019 12:28
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 16, 2019

@bartoldeman I'll let you do the honors on this one, as MotW...

Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bartoldeman bartoldeman merged commit 4eef515 into easybuilders:develop Sep 16, 2019
@boegel boegel deleted the eb_python_order branch September 16, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants